Load unit tests more consistently (pulled from ESM branch)#58481
Merged
jakebailey merged 3 commits intomicrosoft:mainfrom May 9, 2024
Merged
Load unit tests more consistently (pulled from ESM branch)#58481jakebailey merged 3 commits intomicrosoft:mainfrom
jakebailey merged 3 commits intomicrosoft:mainfrom
Conversation
RyanCavanaugh
approved these changes
May 9, 2024
RyanCavanaugh
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back when I did the module transform, I did a weird hack to get test loading to work bundled and unbundled.
Now, having actually spent more time understanding what's going on here, I think this PR is a better way to do the right thing. We just want to do some custom setup, then pull in the tests, then start running them.
Pulled out of #58419.